From rep.dot.nop at gmail.com Mon Jun 3 13:03:08 2024 From: rep.dot.nop at gmail.com (rep.dot.nop at gmail.com) Date: Mon, 03 Jun 2024 15:03:08 +0200 Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_Makerules=3A_fix_out-of-tre?= =?US-ASCII?Q?e_build_error_=22Argument_list_too_long=22?= In-Reply-To: <20240424113655.2382993-1-jcmvbkbc@gmail.com> References: <20240424113655.2382993-1-jcmvbkbc@gmail.com> Message-ID: Hi On 24 April 2024 13:36:55 CEST, Max Filippov wrote: >Make rule that announces and makes static libc archive can generate >command line that is too long when a full path O= option is used. That >breaks the build with the following message: > > make: /bin/sh: Argument list too long > >Use make $(file) construct to generate file list file and use that file >as $(AR) argument instead. Busybox ar does not (yet) support passing in a file containing the list of files, I fear? Can you maybe add support for that, please? thanks > >Signed-off-by: Max Filippov >--- > Makerules | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Makerules b/Makerules >index fe8a7916e657..96f2a71ec49a 100644 >--- a/Makerules >+++ b/Makerules >@@ -276,7 +276,7 @@ cmd_compile.mi= $(cmd_compile.m:-c=-E -dD) $(UCLIBC_EXTRA_CPPFLAGS) > cmd_compile-m = $(CC) $^ -c -o $@ $(CFLAGS) $(CFLAGS-$(suffix $@)) $(CFLAGS-$(notdir $(@D))) $(CFLAGS-$(notdir $@)) $(sort $(foreach d,$(^:$(top_srcdir)=),$(collect_multi_flags))) > cmd_strip = $(STRIPTOOL) $(STRIP_FLAGS) $^ > cmd_t_strip = $(STRIPTOOL) $(STRIP_FLAGS) $@ >-cmd_ar = $(AR) $(ARFLAGS) $@ $(call objects_with_syms,,$^) >+cmd_ar = $(AR) $(ARFLAGS) $@ @$@.list > > define do_ln > @$(disp_ln) >@@ -317,6 +317,7 @@ hcompile.u= @$(disp_hcompile.u); $(cmd_hcompile.u) > hcompile.o= @$(disp_hcompile.o); $(cmd_hcompile.o) > > define do_ar >+ @$(file >$@.list,$(call objects_with_syms,,$^)) > @$(disp_ar) ; $(cmd_ar) > @$(do_t_strip) > endef From jcmvbkbc at gmail.com Mon Jun 3 16:23:33 2024 From: jcmvbkbc at gmail.com (Max Filippov) Date: Mon, 3 Jun 2024 09:23:33 -0700 Subject: [PATCH] Makerules: fix out-of-tree build error "Argument list too long" In-Reply-To: References: <20240424113655.2382993-1-jcmvbkbc@gmail.com> Message-ID: On Mon, Jun 3, 2024 at 6:03?AM wrote: > On 24 April 2024 13:36:55 CEST, Max Filippov wrote: > >Make rule that announces and makes static libc archive can generate > >command line that is too long when a full path O= option is used. That > >breaks the build with the following message: > > > > make: /bin/sh: Argument list too long > > > >Use make $(file) construct to generate file list file and use that file > >as $(AR) argument instead. > > > Busybox ar does not (yet) support passing in a file containing the list of files, I fear? > Can you maybe add support for that, please? At supporting such ar, or at adding support for @file notation to busybox ar? -- Thanks. -- Max From rep.dot.nop at gmail.com Tue Jun 4 06:43:36 2024 From: rep.dot.nop at gmail.com (rep.dot.nop at gmail.com) Date: Tue, 04 Jun 2024 08:43:36 +0200 Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_Makerules=3A_fix_out-of-tre?= =?US-ASCII?Q?e_build_error_=22Argument_list_too_long=22?= In-Reply-To: References: <20240424113655.2382993-1-jcmvbkbc@gmail.com> Message-ID: <37ED05BB-DD3C-4E5B-B499-C1F37DD7A701@gmail.com> On 3 June 2024 18:23:33 CEST, Max Filippov wrote: >On Mon, Jun 3, 2024 at 6:03?AM wrote: >> On 24 April 2024 13:36:55 CEST, Max Filippov wrote: >> >Make rule that announces and makes static libc archive can generate >> >command line that is too long when a full path O= option is used. That >> >breaks the build with the following message: >> > >> > make: /bin/sh: Argument list too long >> > >> >Use make $(file) construct to generate file list file and use that file >> >as $(AR) argument instead. >> >> >> Busybox ar does not (yet) support passing in a file containing the list of files, I fear? >> Can you maybe add support for that, please? > >At supporting such ar, or at adding support for @file notation to busybox ar? > The latter, adding @file support to busybox ar. From jcmvbkbc at gmail.com Tue Jun 4 08:29:09 2024 From: jcmvbkbc at gmail.com (Max Filippov) Date: Tue, 4 Jun 2024 01:29:09 -0700 Subject: [PATCH] Makerules: fix out-of-tree build error "Argument list too long" In-Reply-To: <37ED05BB-DD3C-4E5B-B499-C1F37DD7A701@gmail.com> References: <20240424113655.2382993-1-jcmvbkbc@gmail.com> <37ED05BB-DD3C-4E5B-B499-C1F37DD7A701@gmail.com> Message-ID: On Mon, Jun 3, 2024 at 11:43?PM wrote: > On 3 June 2024 18:23:33 CEST, Max Filippov wrote: > >On Mon, Jun 3, 2024 at 6:03?AM wrote: > >> On 24 April 2024 13:36:55 CEST, Max Filippov wrote: > >> >Make rule that announces and makes static libc archive can generate > >> >command line that is too long when a full path O= option is used. That > >> >breaks the build with the following message: > >> > > >> > make: /bin/sh: Argument list too long > >> > > >> >Use make $(file) construct to generate file list file and use that file > >> >as $(AR) argument instead. > >> > >> Busybox ar does not (yet) support passing in a file containing the list of files, I fear? > >> Can you maybe add support for that, please? > > > >At supporting such ar, or at adding support for @file notation to busybox ar? > > The latter, adding @file support to busybox ar. Sure, I'll take a look. -- Thanks. -- Max