[PATCH v3 1/3] libc: fix setting return value and errno in fallocate()

Anthony G. Basile basile at opensource.dyc.edu
Mon Oct 5 20:57:00 UTC 2015


On 9/23/15 8:43 AM, Yuriy Kolerov wrote:
> fallocate system call must return 0 on success. On error, -1 is returned
> and errno is set to indicate the error.
>

Sorry for coming to the conversation late --- real life.  I did the 
first stab at implementing fallocate() and fallocate64() and I can see 
now I forgot all about errno.  Anyhow, this patch and the other one 
against posix_fallocate() look good.  They should also be backported to 
the 0.9.33 branch which we are using extensively in gentoo.  We can help 
Bernhard out by making sure they apply there cleanly.

I've heard of the linux test project but never played with it.  Sounds 
useful!

-- 
Anthony G. Basile, Ph. D.
Chair of Information Technology
D'Youville College
Buffalo, NY 14201
(716) 829-8197


More information about the uClibc mailing list