[PATCH v2] nptl: remove duplicate vfork() in libpthread

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Thu Jul 30 18:53:38 UTC 2015


On July 24, 2015 9:17:27 AM GMT+02:00, Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
>On Friday 24 July 2015 09:26 AM, Bernhard Reutner-Fischer wrote:
>> On July 22, 2015 5:05:34 PM GMT+02:00, Alexey Brodkin
><Alexey.Brodkin at synopsys.com> wrote:
>>> >Hi Bernard,
>>> >This patch indeed fixes problems with duplicate vfork in both libc
>and
>>> >libpthread.
>>> >I'm wondering if there's a chance for this patch to be applied
>still?
>> Well, but it's wrong, isn't it. 
>
>Is it ? It makes pthread also use the libc version. The only difference
>between
>them was pthread version had a small optimization which could be done
>away
>altogether with if u read thru the tread below.
>
>https://sourceware.org/ml/libc-alpha/2014-05/msg00238.html
>
>> pt-vfork.o should instead live in, say,  libpthread_nonshared.a and
>be at the end of the libs so it is picked up by the linker when static
>linking, no?
>
>Could be done that way too but not needed if above is sufficient.

Above makes RESET_PID superfluous, doesn't it.

Care to send an updated patch?
Thanks,
>
>-Vineet




More information about the uClibc mailing list