[PATCH v2] nptl: remove duplicate vfork() in libpthread

Alexey Brodkin Alexey.Brodkin at synopsys.com
Wed Jul 22 15:05:34 UTC 2015


Hi Bernard,

On Mon, 2014-09-08 at 18:44 +0200, Waldemar Brodkorb wrote:
> Automatic patching via two oneliners by Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>:
> sed -i -e 's/[[:space:]]pt-vfork\.[csS]//' -e '/^ASFLAGS-pt-vfork\./d' $(git grep -l pt-vfork libpthread/nptl/sysdeps)
> find libpthread/nptl -name "*pt-vfork*" -exec git rm {} \;
> 
> Reported-By: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Tested-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Signed-off-by: Waldemar Brodkorb <wbx at openadk.org>
> 
> ---
> Changes in v2:
>  * removed ASFLAGS suggested by Eugene Rudoy <gene.devel at gmail.com>
> 
> ---
>  .../nptl/sysdeps/unix/sysv/linux/alpha/pt-vfork.S  | 42 --------------
>  .../nptl/sysdeps/unix/sysv/linux/arc/Makefile.arch |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/arc/pt-vfork.S    |  7 ---
>  .../nptl/sysdeps/unix/sysv/linux/arm/Makefile.arch |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/arm/pt-vfork.S    | 37 ------------
>  .../sysdeps/unix/sysv/linux/i386/Makefile.arch     |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/i386/pt-vfork.S   | 67 ----------------------
>  .../sysdeps/unix/sysv/linux/metag/Makefile.arch    |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/metag/pt-vfork.S  | 51 ----------------
>  .../sysdeps/unix/sysv/linux/mips/Makefile.arch     |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/mips/pt-vfork.S   | 37 ------------
>  .../sysdeps/unix/sysv/linux/powerpc/Makefile.arch  |  3 +-
>  .../unix/sysv/linux/powerpc/powerpc32/pt-vfork.S   | 48 ----------------
>  .../unix/sysv/linux/powerpc/powerpc64/pt-vfork.S   | 48 ----------------
>  .../sysdeps/unix/sysv/linux/powerpc/pt-vfork.S     |  5 --
>  .../nptl/sysdeps/unix/sysv/linux/sh/Makefile.arch  |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/sh/pt-vfork.S     | 64 ---------------------
>  .../sysdeps/unix/sysv/linux/sparc/Makefile.arch    |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/sparc/pt-vfork.S  | 44 --------------
>  .../sysdeps/unix/sysv/linux/x86_64/Makefile.arch   |  3 +-
>  .../nptl/sysdeps/unix/sysv/linux/x86_64/pt-vfork.S | 32 -----------
>  21 files changed, 9 insertions(+), 500 deletions(-)
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/alpha/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/arc/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/arm/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/i386/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/metag/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/mips/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/powerpc/powerpc32/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/powerpc/powerpc64/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/powerpc/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/sh/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/sparc/pt-vfork.S
>  delete mode 100644 libpthread/nptl/sysdeps/unix/sysv/linux/x86_64/pt-vfork.S

This patch indeed fixes problems with duplicate vfork in both libc and libpthread.
I'm wondering if there's a chance for this patch to be applied still?

Fortunately it applies cleanly on top of current master still.

-Alexey


More information about the uClibc mailing list