[PATCH] nptl: remove duplicate vfork() in libpthread

Waldemar Brodkorb wbx at openadk.org
Mon Sep 8 16:36:46 UTC 2014


Hi Eugene,
Eugene Rudoy wrote,

> Hi Waldemar,
> 
> On Fri, Sep 5, 2014 at 4:13 PM, Waldemar Brodkorb <wbx at openadk.org> wrote:
> 
>     Automatic patching via two oneliners from Bernhard Reutner-Fischer <
>     rep.dot.nop at gmail.com>:
>     sed -i -e 's/[[:space:]]pt-vfork\.[csS]//' $(git grep -l pt-vfork
>     libpthread/nptl/sysdeps)
>     find libpthread/nptl -name "*pt-vfork*" -exec git rm {} \;
> 
> 
> not sure if this really matters... just wanted to point out that libc- and
> libpthread-versions of vfork are not exactly identical - on some archs it's
> just a different definition of SAVE_PID/RESTORE_PID, on some archs a littile
> bit more:
> for d in $(find libpthread/nptl -name "pt-vfork.S" -printf "%h\n"); do diff -u
> $d/pt-vfork.S $d/vfork.S; done

Yeah, we know there is a difference, but glibc removed the
micro optimized versions of vfork for NPTL and so we should do, to
avoid static linking problems.
 
> If this doesn't matter and the pt-vfork versions should all really be deleted
> then the 1st of your oneliners should be extended a bit (Makefiles still
> contain the no more necessary ASFLAGS-pt-vfork entries):
> sed -i -e 's/[[:space:]]pt-vfork\.[csS]//' -e '/^ASFLAGS-pt-vfork\./ d' $(git
> grep -l pt-vfork libpthread/nptl/sysdeps)

The oneline was from Bernhard ;)
But you are right, the empty stuff should be removed.

best regards
 Waldemar


More information about the uClibc mailing list