[PATCH 1/2] test/tls/tst-tls[6-8]: Fix build errors

[Baruch Siach]

Hi Vineet,

On Thu, Feb 06, 2014 at 12:42:08PM +0000, Vineet Gupta wrote:
> On Thursday 06 February 2014 05:53 PM, Baruch Siach wrote:
> > Hi Vineet,
> >
> > On Thu, Feb 06, 2014 at 05:49:21PM +0530, Vineet Gupta wrote:
> >> --------------->8-------------------
> >> tst-tls7.c: In function 'do_test':
> >> tst-tls7.c:39:57: error: 'struct link_map' has no member named 'l_tls_modid'
> >>   modid = ((struct link_map *)((struct dyn_elf *)h)->dyn)->l_tls_modid;
> >>                                                          ^
> >> tst-tls7.c:40:63: error: 'struct link_map' has no member named 'l_tls_modid'
> >>        else if (((struct link_map *)((struct dyn_elf *)h)->dyn)->l_tls_modid
> >>                                                                ^
> >> tst-tls7.c:45:52: error: 'struct link_map' has no member named 'l_tls_modid'
> >>      ((struct link_map *)((struct dyn_elf *)h)->dyn)->l_tls_modid,
> >>                                                     ^
> >> make[2]: *** [tst-tls7] Error 1
> >> --------------->8-------------------
> > I used a different approach to fix the same issue some while ago: 
> > http://article.gmane.org/gmane.comp.lib.uclibc.general/23449 . Does this work 
> > for you?
> 
> It does - thanks and indeed smaller patch.
> What's your opinion on the other one, does it make sense ?

I haven't looked too deeply into it, but the fix looks correct. The original 
glibc version of this test (elf/tst-tls8.c) seems to need the same fix (with 
the uClibc specific part removed). You probably have better chance of having 
your patch reviewed (and applied) on the glibc list.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -