[PATCH] librt: fix mq_timed{send,receive} return instructions

Baruch Siach baruch at tkos.co.il
Thu Nov 7 05:50:13 UTC 2013


Hi Bernhard,

On Wed, Nov 06, 2013 at 11:03:17PM +0100, Bernhard Reutner-Fischer wrote:
> On 6 November 2013 22:35, Bernhard Reutner-Fischer
> <rep.dot.nop at gmail.com> wrote:
> > On 3 November 2013 17:20, Baruch Siach <baruch at tkos.co.il> wrote:
> >> Not all architectures use 'ret' as function return instruction. For example,
> >> xtensa usually uses 'retw'. Use the ret_ERRVAL arch dependant macro instead.
> >
> > yea. Did you grep for other occurances?
> 
> specifically, you'd just broke these arches, if i'm not mistaken:
> 
> git grep -L ret_ERRVAL libc/sysdeps/linux/*/sysdep.h | while read l;do
> basename $(dirname $l);done | grep -v common
> bfin
> cris
> metag
> powerpc

powerpc variants are under their own subdirectory:

libc/sysdeps/linux/powerpc/powerpc32/sysdep.h:#define ret_ERRVAL PSEUDO_RET_ERRVAL
libc/sysdeps/linux/powerpc/powerpc64/sysdep.h:#define ret_ERRVAL PSEUDO_RET_ERRVAL

> sparc
> 
> Please resend.
> thanks,

I'll add

#define ret_ERRVAL ret

to sysdep.h of other architectures, and resubmit,

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


More information about the uClibc mailing list