[PATCH 3/7] leek: if lseek syscall is not available, use lseek64 even for !LFS

Markos Chandras markos.chandras at gmail.com
Tue Mar 12 15:09:44 UTC 2013


On 11 March 2013 13:21, Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
> +       __off64_t result;
> +       __off_t high = 0;
> +       return INLINE_SYSCALL(llseek, 5, fd,
> +                               __LONG_LONG_PAIR(high, offset),
> +                               &result, whence) ?: result;
> +#endif
> +/* No need to handle __WORDSIZE == 64 as such a kernel won't define __NR_llseek */
>  }
>  #else
>  # include <errno.h>
> --

That looks ok but I see no reason to define 'high' to be 0. Couldn't
you pass '0' directly to INLINE_SYSCALL?

-- 
Regards,
Markos Chandras


More information about the uClibc mailing list