[PATCH 4/7] libpthread: linuxthreads{, .old}: Allow building for no-legacy-syscalls ABI

Markos Chandras markos.chandras at gmail.com
Mon Mar 11 13:43:33 UTC 2013


On 11 March 2013 13:39, Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
> On Monday 11 March 2013 07:04 PM, Markos Chandras wrote:
>> On 11 March 2013 13:21, Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
>>> Since NPTL port to an ARCH can be non-trivial, we must allow the legacy
>>> pthread lib to be built for the common-generic syscall ABI
>>>
>>> Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
>>> Cc: Markos Chandras <markos.chandras at imgtec.com>
>>> ---
>>>  extra/Configs/Config.in |    2 --
>>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/extra/Configs/Config.in b/extra/Configs/Config.in
>>> index 1c6277a..f266d35 100644
>>> --- a/extra/Configs/Config.in
>>> +++ b/extra/Configs/Config.in
>>> @@ -498,7 +498,6 @@ config HAS_NO_THREADS
>>>
>>>  config LINUXTHREADS_OLD
>>>         bool "older (stable) version of linuxthreads"
>>> -       depends on ARCH_HAS_DEPRECATED_SYSCALLS
>>>         # linuxthreads and linuxthreads.old need nanosleep()
>>>         select UCLIBC_HAS_REALTIME
>>>         help
>>> @@ -509,7 +508,6 @@ config LINUXTHREADS_OLD
>>>
>>>  config LINUXTHREADS_NEW
>>>         bool "slightly newer version of linuxthreads"
>>> -       depends on ARCH_HAS_DEPRECATED_SYSCALLS
>>>         help
>>>           The new version has not been tested much, and lacks ports for arches
>>>           which glibc does not support (like bfin/frv/etc...), but is based on
>>> --
>>> 1.7.4.1
>>>
>>> _______________________________________________
>>> uClibc mailing list
>>> uClibc at uclibc.org
>>> http://lists.busybox.net/mailman/listinfo/uclibc
>> I don't think this is correct.
>> libpthread/linuxthreads/sysdeps/unix/sysv/linux/smp.h uses the
>> sysctl() syscall which does not exist for new architectures.
>> Did you actually manage to compile linuxthreads(new) on a new arch?
>
> Nope - I'm currently using linuxthreads.old and threading seems to be running fine
> on it.
> I did the fix for both - just to maintain the symmetry - which hence is incorrect.
> So I need to do that only for linxthreads.old - do you have any reservations
> against that.
>
> -Vineet
>

Nope. If it works for you then that's fine.

-- 
Regards,
Markos Chandras


More information about the uClibc mailing list