[PATCHv2] Rules.mak: fix breakage from 603af30d

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Fri Jul 26 07:30:14 UTC 2013


On Wed, Jul 24, 2013 at 04:41:44PM +0100, Markos Chandras wrote:
> On 24 July 2013 16:30, Gustavo Zacarias <gustavo at zacarias.com.ar> wrote:
> > Removing the whitespace from findstring for 64 bit architectures has
> > bad consequences since powerpc would be a match in powerpc64 and sparc
> > would also be a match in sparc64.
> > That doesn't make them 64 bits in reality causing general breakage.
> >
> > Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
> > ---
> >  Rules.mak | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Rules.mak b/Rules.mak
> > index 889108e..be53d81 100644
> > --- a/Rules.mak
> > +++ b/Rules.mak
> > @@ -141,7 +141,7 @@ UBACKTRACE_DSO := libubacktrace.so.$(ABI_VERSION)
> >
> >  UCLIBC_LDSO_NAME := ld-uClibc
> >  ARCH_NATIVE_BIT := 32
> > -ifneq ($(findstring $(TARGET_ARCH),hppa64 ia64 powerpc64 s390x sparc64 x86_64),)
> > +ifneq ($(findstring  $(TARGET_ARCH) , hppa64 ia64 powerpc64 s390x sparc64 x86_64 ),)
> >  UCLIBC_LDSO_NAME := ld64-uClibc
> >  ARCH_NATIVE_BIT := 64
> >  else
> > --
> > 1.8.1.5
> >
> > _______________________________________________
> > uClibc mailing list
> > uClibc at uclibc.org
> > http://lists.busybox.net/mailman/listinfo/uclibc
> 
> Thank you for the v2. The patch looks good to me
> 
> Reviewed-by: Markos Chandras <markos.chandras at imgtec.com>

Applied, thanks!


More information about the uClibc mailing list