[PATCH V2] ldso: fix fdpic support broken from prelink patch

[Mike Frysinger]

On Monday 26 March 2012 10:36:54 Filippo ARCIDIACONO wrote:
> From: Mike Frysinger [mailto:vapier at gentoo.org]
> > On Wednesday 07 March 2012 04:07:01 Filippo ARCIDIACONO wrote:
> > > --- a/ldso/ldso/c6x/dl-sysdep.h
> > > +++ b/ldso/ldso/c6x/dl-sysdep.h
> > > 
> > > +/* Define this to set the library offset. */ #ifndef
> > > +DL_SET_LIB_OFFSET # define DL_SET_LIB_OFFSET(offset)
> > > +(_dl_library_offset = 0) #endif
> > > +
> > > +/* Define this to get the real object's load address. */ #ifndef
> > > +DL_GET_LOADADDR_MAPADDR # define DL_GET_LOADADDR_MAPADDR(loadaddr,
> > > +mapaddr) (loadaddr) #endif
> > 
> > using ifndef in these arch files doesn't make much sense.  just drop
> > those checks.
> 
> You are right. I missed.
> 
> > also, seems like _dl_library_offset is always set to 0.
> 
> _dl_library_offset is 0 for fdpic and c6x archs only.

yes ... i was quoting the arch-specific headers when pointing this out

> > would make more sense i think to have the macro read:
> > #define DL_SET_LIB_OFFSET(offset)
> > 
> > and then add a new macro for declaring the _dl_library_offset variable
> > which the common code would use to setup a static, and these arches
> > would define to 0
> 
> IIUC, I should add something like:
> 
> #define DEF_LIBRARY_OFFSET() static unsigned long _dl_library_offset
> 
> For common code, while for c6x and fdpic:
> 
> #define DEF_LIBRARY_OFFSET() unsigned long _dl_library_offset = 0
> 
> Is this what you mean?

for common code that is correct.  for c6x/fdpic, it should just be:
#define DEF_LIBRARY_OFFSET()
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20120326/73f73260/attachment.asc>