[PATCH V2] ldso: fix fdpic support broken from prelink patch

Mike Frysinger vapier at gentoo.org
Sun Mar 25 06:14:36 UTC 2012

On Wednesday 07 March 2012 04:07:01 Filippo ARCIDIACONO wrote:
> The fdpic support has been broken since the prelink support was added,
> because it didn't take into account DL_LOADADDR_TYPE could be a different
> type of ElfW(Addr).

it compiles now, so that's an improvement :).  i don't have hardware setup atm 
to test the runtime, but i wouldn't be surprised if there were other issues 
unrelated that'd break things.

> --- a/ldso/ldso/c6x/dl-sysdep.h
> +++ b/ldso/ldso/c6x/dl-sysdep.h
> +/* Define this to set the library offset. */
> +#ifndef DL_SET_LIB_OFFSET
> +# define DL_SET_LIB_OFFSET(offset) (_dl_library_offset = 0)
> +#endif
> +
> +/* Define this to get the real object's load address. */
> +# define DL_GET_LOADADDR_MAPADDR(loadaddr, mapaddr) (loadaddr)
> +#endif

using ifndef in these arch files doesn't make much sense.  just drop those 

also, seems like _dl_library_offset is always set to 0.  would make more sense 
i think to have the macro read:
#define DL_SET_LIB_OFFSET(offset)

and then add a new macro for declaring the _dl_library_offset variable which 
the common code would use to setup a static, and these arches would define to 0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20120325/ad5fe7fe/attachment.asc>

More information about the uClibc mailing list