[PATCH] prevent retries on fclose/fflush after write errors

Mike Frysinger vapier at gentoo.org
Tue Mar 13 20:24:33 UTC 2012


On Tuesday 13 March 2012 15:32:01 Rich Felker wrote:
> On Tue, Mar 13, 2012 at 07:19:35PM +0000, u-uclibc-qs50 at aetey.se wrote:
> > > there's no correct/sane
> > > program that would be affected by this ABI change.
> > 
> > Actually I suspect that stdio macros might use stuff (like __bufpos)
> > which is located past the proposed new structure member, in which case
> > existing binaries would become incompatible with a patched library:
> >
> > >>>  #endif /* __UCLIBC_HAS_WCHAR__ */
> > >>>  	int __filedes;
> > >>> +	int __errno_value;
> > >>>  #ifdef __STDIO_BUFFERS
> > >>>  	unsigned char *__bufstart;	/* pointer to buffer */
> > >>>  	unsigned char *__bufend;	/* pointer to 1 past end of buffer */
> > 
> > ->      unsigned char *__bufpos;
> 
> Indeed, I missed this. It should definitely not be added near the
> beginning of the structure, only past elements that could be part of
> the macro ABI.

that would help only if the uClibc code itself had versioned functions which 
handled the growing struct.  if you're attempting to support code that 
allocated sizeof(FILE) memory (which is dumb), then location in the struct 
wouldn't matter.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20120313/43bd071d/attachment.asc>


More information about the uClibc mailing list