[PATCH] prevent retries on fclose/fflush after write errors

Rich Felker dalias at aerifal.cx
Tue Mar 13 19:32:01 UTC 2012


On Tue, Mar 13, 2012 at 07:19:35PM +0000, u-uclibc-qs50 at aetey.se wrote:
> > there's no correct/sane
> > program that would be affected by this ABI change.
> 
> Actually I suspect that stdio macros might use stuff (like __bufpos)
> which is located past the proposed new structure member, in which case
> existing binaries would become incompatible with a patched library:
> 
> >>>  #endif /* __UCLIBC_HAS_WCHAR__ */
> >>>  	int __filedes;
> >>> +	int __errno_value;
> >>>  #ifdef __STDIO_BUFFERS
> >>>  	unsigned char *__bufstart;	/* pointer to buffer */
> >>>  	unsigned char *__bufend;	/* pointer to 1 past end of buffer */
> ->      unsigned char *__bufpos;

Indeed, I missed this. It should definitely not be added near the
beginning of the structure, only past elements that could be part of
the macro ABI.

Rich


More information about the uClibc mailing list