[PATCH] prevent retries on fclose/fflush after write errors

Rich Felker dalias at aerifal.cx
Tue Mar 13 14:36:48 UTC 2012

On Tue, Mar 13, 2012 at 07:16:54AM +0000, u-uclibc-qs50 at aetey.se wrote:
> On Tue, Mar 13, 2012 at 01:58:49AM -0400, Rich Felker wrote:
> > On Tue, Mar 13, 2012 at 01:41:01AM -0400, Mike Frysinger wrote:
> > > >  	int __filedes;
> > > > +	int __errno_value;
> > > pretty sure this breaks ABI.  i know we aren't completely strict on this, but 
> > > it's something we should avoid if possible.
> > 
> > How so? Application code should not be touching the internals of
> > FILE...
> You are right Rich but it seems you are thinking of API while this change
> breaks ABI.

If it does, I still don't see how it could. Applications cannot
declare objects of type FILE, only FILE *. Short of some macros that
poke at the early members of the structure (getc/putc macros), it's
purely an opaque type, so changes to its size or layout (beyond said
early members) should not break ABI. If you claim it does, please
explain how you think it does, because the rest of us are missing that


More information about the uClibc mailing list