[PATCH 1/2] MIPS: Convert __syscall_error() callers to use $a0 for argument

Kevin Cernekee cernekee at gmail.com
Wed Jun 6 17:54:12 UTC 2012


On Wed, Jun 6, 2012 at 12:38 AM, Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
> On Tue, Jun 05, 2012 at 03:05:19PM -0700, Kevin Cernekee wrote:
>>Some callers passed the first argument in $v0, while others used $a0.
>>Change the callers to use $a0 consistently.
>
> Applied the series, thanks!
> Are linuxthreads.old and nptl consistent with this linuxthreads change?

I am running NPTL libpthread, whose call sites were fixed a while back
in commit 9a4c8a3f2 (mips: fix errno setting after syscall).

I did not see any __syscall_error() calls in linuxthreads.old .  I did
grep for all __syscall_error() callers on MIPS, to ensure that all of
them were using $a0 now.

Normally __syscall_error() isn't called explicitly from
librt/libpthread/etc. except for special cases; instead, it is called
from a wrapper like PSEUDO.  The wrappers were already in good shape,
but my first patch was required to fix up some of the special cases.


More information about the uClibc mailing list