ftruncate with LFS OFF (was Re: [PATCH v2 24/46] ftruncate: Use ftruncate64 if arch does not have the ftruncate syscall)

Markos Chandras markos.chandras at gmail.com
Mon Dec 10 09:32:38 UTC 2012


On 10 December 2012 05:26, Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
>
>> The fix looks reasonable to me (probably similar fixes for the
>> other syscalls apply too, except for the getdents one that looks a bit
>> complicated.) However, I am affraid that the code might become a bit
>> unreadable
>> with all the #if/#def mess.
>
> !LFS support doesn't add lot more than what we already have. The 3 which
> seem to fail for me are easily fixable. I've not seen any breakage with
> getdents

I will rebase the branch with fixes for all of them

>
>> Another "workaround" for this is new
>> architectures to always "select UCLIBC_HAS_LFS" in ther Kconfig files.
>
> Remember uClibc is all about smaller code footprint - this is not
> acceptable !

That's why I said "workaround" :)

Thanks for testing these patches.

-- 
Regards,
Markos


More information about the uClibc mailing list