[PATCH uClibc++] buildsys: do not assume /bin/sh is a bash shell

Florian Fainelli florian at openwrt.org
Tue Aug 7 08:37:39 UTC 2012


Hello Bernhard,

On Monday 06 August 2012 23:26:22 Bernhard Reutner-Fischer wrote:
> On 6 Aug 2012 11:09, "Felix Fietkau" <nbd at openwrt.org> wrote:
> >
> > Instead use /usr/bin/env to run a bash shell, fixes some portability
> > issues on hosts such as Mac OSX or dash-based systems.
> 
> Iirc I removed all bashisms, the wrapper runs fine for me with dash (and
> Busybox ash).
> What problems do you encounter?

Actually this is an old patch we had in our repository, and checking with 
Felix, this does no longer seem to be required.

Thank you.

> Thanks,
> >
> > Signed-off-by: Felix Fietkau <nbd at openwrt.org>
> > Signed-off-by: Florian Fainelli <florian at openwrt.org>
> > ---
> >  bin/Makefile |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bin/Makefile b/bin/Makefile
> > index acf3b95..4c6c713 100644
> > --- a/bin/Makefile
> > +++ b/bin/Makefile
> > @@ -13,7 +13,7 @@ install:
> >         $(INSTALL) -m 755 $(WRAPPER) $(PREFIX)$(UCLIBCXX_RUNTIME_BINDIR)
> >
> >  $(WRAPPER): Makefile
> > -       echo '#!/bin/sh' > $@
> > +       echo '#!/usr/bin/env bash' > $@
> >         echo '' >> $@
> >         echo
> 'WRAPPER_INCLUDEDIR="$${WRAPPER_INCLUDEDIR:=-
I$(UCLIBCXX_RUNTIME_INCLUDEDIR)}"'
> >> $@
> >         echo
> 'WRAPPER_LIBDIR="$${WRAPPER_LIBDIR:=-L$(UCLIBCXX_RUNTIME_LIBDIR)}"' >> $@
> > --
> > 1.7.9.5
> >


More information about the uClibc mailing list