[PATCH] buildsys: s/CROSS/CROSS_COMPILE/g

Mike Frysinger vapier at gentoo.org
Sun Nov 20 08:07:36 UTC 2011


On Friday 28 October 2011 00:32:35 Carmelo AMOROSO wrote:
> On 27/10/2011 23.04, Mike Frysinger wrote:
> > On Thu, Oct 27, 2011 at 17:54, Carmelo AMOROSO wrote:
> >> On 27/10/2011 17.32, Mike Frysinger wrote:
> >>> On Thu, Oct 27, 2011 at 16:42, Carmelo AMOROSO wrote:
> >>>> +ifndef CROSS_COMPILE
> >>>> +CROSS_COMPILE=
> >>>>  endif
> >>> 
> >>> this is kind of useless logic.  i would change it to one line:
> >>> CROSS_COMPILE ?= $(CROSS)
> >> 
> >> I've really done a sed, so I've kept the original logic.
> >> IIUC you are suggesting to keep both CROSS and CROSS_COMPILE option,
> >> If so, it should be the opposite
> >> 
> >> CROSS ?= $(CROSS_COMPILE)
> >> 
> >> shouldn't it ?
> > 
> > considering you changed everything else to use $(CROSS_COMPILE), i
> > think what i proposed makes the most sense.
> 
> I've understood you suggested to keep the code as is, and in case
> CROSS_COMPILE was used, use it to set CROSS.

i'll try to be clear then: we should use CROSS_COMPILE everywhere, and the 
only place $(CROSS) should show up is as the default value of CROSS_COMPILE 
(purely to keep existing systems that compile uClibc working).  so rather than 
this:
	ifndef CROSS_COMPILE
	CROSS_COMPILE=
	endif
use this one line:
	CROSS_COMPILE ?= $(CROSS)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20111120/4a0a4eb3/attachment.asc>


More information about the uClibc mailing list