[PATCH] getaddrinfo: allow numeric service without any hints

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Tue Jun 14 08:50:25 UTC 2011


On Sun, Jun 12, 2011 at 12:09:04PM +0000, Natanael Copa wrote:
>This appears to correspond to what glibc does and this fixes an
>issue with iptables-1.4.11 with udp and raw port numbers.
>
>(see http://bugzilla.netfilter.org/show_bug.cgi?id=721)
>
>This fixes #3841
>https://bugs.busybox.net/show_bug.cgi?id=3841
>
>Signed-off-by: Natanael Copa <natanael.copa at gmail.com>

applied, thanks.

>---
> libc/inet/getaddrinfo.c |    7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
>diff --git a/libc/inet/getaddrinfo.c b/libc/inet/getaddrinfo.c
>index 1a77c51..e7511f6 100644
>--- a/libc/inet/getaddrinfo.c
>+++ b/libc/inet/getaddrinfo.c
>@@ -820,13 +820,6 @@ getaddrinfo(const char *name, const char *service,
> 			if (hints->ai_flags & AI_NUMERICSERV)
> 				return EAI_NONAME;
> 			gaih_service.num = -1;
>-		} else {
>-			/*
>-			 * Can't specify a numerical socket unless a protocol
>-			 * family was given.
>-			 */
>-			if (hints->ai_socktype == 0 && hints->ai_protocol == 0)
>-				return EAI_SERVICE;
> 		}
> 		pservice = &gaih_service;
> 	} else
>-- 
>1.7.5.4
>


More information about the uClibc mailing list