ipc.h struct layout fix

Peter Mazinger ps.m at gmx.net
Thu Jul 7 18:41:14 UTC 2011


Hi,
> This fixes a problem identified by Mark Salter on C6X big-endian
> systems. We should not use "unsigned short int mode"; the proper type is
> in theory mode_t, but here we need to use kernel_mode_t since this
> structure is used for communication with the kernel, and some targets
> have a 16-bit kernel_mode_t and 32-bit mode_t.

haven't looked closely, but if this header gets installed on target, [__]kernel_mode_t is not/should not be defined. If the structure is not meant to be used on target, than it should be guarded (like _LIBC), else we should use mode_t here and handle accordingly in code.

Peter
> 
> Please also compare linux-2.6/include/asm-generic/ipcbuf.h, which uses
> the same definition for mode/pad1 as the one introduced by the patch.
> 
> 
> Bernd

-- 
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de


More information about the uClibc mailing list