[PATCH 3/3] Add __pause_nocancel weak alias.

Will Newton will.newton at gmail.com
Wed Jan 19 09:53:39 UTC 2011


On Wed, Jan 19, 2011 at 9:12 AM, Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
>> diff --git a/libc/sysdeps/linux/common/pause.c
>> b/libc/sysdeps/linux/common/pause.c
>> index ab16fa7..036f6a3 100644
>> --- a/libc/sysdeps/linux/common/pause.c
>> +++ b/libc/sysdeps/linux/common/pause.c
>> @@ -34,6 +34,7 @@ __libc_pause (void)
>> return sigsuspend (&set);
>> }
>> weak_alias (__libc_pause, pause)
>> +weak_alias (__libc_pause, __pause_nocancel)
>>
>> #ifdef __UCLIBC_HAS_THREADS_NATIVE__
>> LIBC_CANCEL_HANDLED (); /* sigsuspend handles our cancellation. */
>
> Hi Will,
> if you use NPTL (do you ?), due to the call to sigsupend (that is a
> cancellable function too) your __pause_nocancel is actually a
> cancellation point. So I'm not sure you issue is fixed.

Our NPTL port is not fully tested yet, so this may be an issue, I'll
look into it.

Thanks for the review!


More information about the uClibc mailing list