[PATCH 4/7] ARM: transform the EABI/OABI choice into a boolean

Carmelo AMOROSO carmelo.amoroso at st.com
Wed Jan 12 07:25:48 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/12/2011 8:13 AM, Khem Raj wrote:
> On Tue, Jan 11, 2011 at 10:50 PM, Carmelo AMOROSO
> <carmelo.amoroso at st.com> wrote:
> On 1/9/2011 1:45 AM, Yann E. MORIN wrote:
>>  >> The CONFIG_ARM_OABI option is never used.
>>  >>
>>  >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at anciens.enib.fr>
>>  >> Cc: Khem Raj <raj.khem at gmail.com>
>>  >> Cc: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
>>  >> Cc: Carmelo AMOROSO <carmelo.amoroso at st.com>
>>  >> ---
>>  >> extra/Configs/Config.arm | 23 ++++++++---------------
>>  >> 1 files changed, 8 insertions(+), 15 deletions(-)
>>  >>
>>  >> diff --git a/extra/Configs/Config.arm b/extra/Configs/Config.arm
>>  >> index 6c75a00..227b90c 100644
>>  >> --- a/extra/Configs/Config.arm
>>  >> +++ b/extra/Configs/Config.arm
>>  >> @@ -12,23 +12,16 @@ config FORCE_OPTIONS_FOR_ARCH
>>  >> default y
>>  >> select ARCH_ANY_ENDIAN
>>  >>
>>  >> -choice
>>  >> - prompt "Target ABI"
>>  >> - default CONFIG_ARM_OABI
>>  >> +config CONFIG_ARM_EABI
>>  >> + bool "Build for EABI"
>>  >> help
>>  >> - If you choose "EABI" here, functions and constants required by the
>>  >> - ARM EABI will be built into the library. You should choose "EABI"
>>  >> + If you say 'y' here, functions and constants required by the
>>  >> + ARM EABI will be built into the library. You should say 'y'
>>  >> if your compiler uses the ARM EABI, in which case you will also
>>  >> - need a kernel supporting the EABI system call interface, or "OABI"
>>  >> - for a compiler using the old Linux ABI.
>>  >> -
>>  >> -config CONFIG_ARM_OABI
>>  >> - bool "OABI"
>>  >> -
>>  >> -config CONFIG_ARM_EABI
>>  >> - bool "EABI"
>>  >> -
>>  >> -endchoice
>>  >> + need a kernel supporting the EABI system call interface.
>>  >> +
>>  >> + If you say 'n' here, then the library will be built for the
>>  >> + old Linux ABI.
>>  >>
>>  >> config COMPILE_IN_THUMB_MODE
>>  >> bool "Build using Thumb mode"
>>  >> --
>>  >> 1.7.1
>>  >>
> 
> This one applies with a warning due to white space. All others apply
> fine and work fine as well. Build tested with a gcc 4.5.0 configured for
> arm926ej-s and arm1136jfs.
> 
> I would proceed to push on master ... do we agree ?
> 
>> No do not push them yet. We are in rc stage once we cut out the branch
>> then we can push
> 

you're right. I won't.

ciao
> 
> Thanks,
> Carmelo
> 
>  >

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0tV3wACgkQoRq/3BrK1s/JVgCeL2EFFcoiB05hFDjPbFQ1Wxip
Qk0AoIlbddv4V0hQO1xSkBkc8RsdhHid
=JW5I
-----END PGP SIGNATURE-----


More information about the uClibc mailing list