[RFC] git master broken due to config parser

[Natanael Copa]

On Tue, Oct 5, 2010 at 11:44 AM, Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/5/2010 10:14 AM, Natanael Copa wrote:
>> Hi,
>>
>
> Hi Natanael,

Hi, thanks for your response. I was hoping to close this issue this
week but incredible how time flies...

...
>> So, I have a few options I think we should evaluate:
>>
>> 1. Revert the config parser commits, create a feature branch and put
>> them there, where they can be debugged without stress.
>>
>> 2. Raise the line buffer size to 256 chars, which it seems to have
>> been before. (things that still break at that size would probably have
>> broken before too). Then rip out the code that tries to be smart by
>> doing realloc when line buffer is too small.
>>
>> 3. Keep line buffer to 80 chars and fix the realloc logic, now.
>>
>> Option #2 and #3 implies that the patches[1][2][3] gets applied.
>>
>
> I do not know "config_parser" at all, but I looked your patch times ago
> and was thinking to push them. I was busy with prelink stuff.
>
>> I have some ideas for option #3, but not sure yet if it will work. The
>> code will be somewhat complicated so I think the extra bytes saved
>> might get lost in the extra code.
>>
>> In any case, I think we should do something *soon*, since current git
>> master have been broken for too long. I can help but i need someone to
>> review (sign-off?) and someone with git push access to get the changes
>> in git master.
>>
>
> Honestly I'm not seeing any activities on uClibc in the last month.
> I would opt for option #2 and #3. If config_parse needs to be reworked,
> it can be done as well later.
>
> I agree with you to have master fixed asap.

Great. Lets rule out running the config parser in separate branch.
Then we should decide if we want stay simple and allways alloc 256
chars static, or try be smart and start with 80 and then dynamically
increase if needed. I think Bernhard wanted the latter.

I'll have a look at it.

> I can help pushing your patches [1][2] and [3].

That would be great. They don't make things worse at least.

-- 
Natanael Copa