[git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

Mike Frysinger vapier at gentoo.org
Sun Sep 6 06:18:10 UTC 2009


On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote:
> On Saturday 05 September 2009 23:55, Mike Frysinger wrote:
> > On Saturday 05 September 2009 17:55:26 Denys Vlasenko wrote:
> > > >On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote:
> > > >> +#ifndef O_CLOEXEC
> > > >> +# define O_CLOEXEC 0
> > > >> +#endif
> > > >
> > > >it should be defined by the C library headers.  if it isnt, then the
> > > > port needs updating and the build should fail.  so please drop this
> > > > cruft.
> > >
> > > You probably was thinking about FD_CLOEXEC. :)
> > >
> > > Yes, FD_CLOEXEC must exist.
> > >
> > > O_CLOEXEC is a new, Linux specific open() flag.
> > > And currently it is not yet defined, since there are many
> > > old kernels in the wild which won't understand that.
> >
> > no, i'm thinking of O_CLOEXEC.  i know what the flag is for, and it
> > should be defined in bits/fcntl.h for every port.
>
> Currently, it is not defined on any arch:

then you fix/update the arches instead of ignoring the problem and sprinkling 
cruft everywhere
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20090906/3ce104d0/attachment.pgp>


More information about the uClibc mailing list