[PATCH 00/13] Cleanup for gcc-4.4

[Ron]

Hi,

I've been updating our toolchain to use gcc-4.4 and uclibc from the current
master HEAD.  The following patches clean up a number of things that new gcc
complains about. It's not everything, but this lot at least should be fairly
uncontroversial and will give us a somewhat cleaner slate for looking at the
more tricky issues.

I've mostly grouped them by the issue they fix, but split them with a finer
granularity where an alternative might be desired or where it seemed useful
for a change to be bisectable later.

Cheers,
Ron


  Add some missing printf/scanf format attributes
  Move extern prototype out of function scope
  Add noreturn attributes to some functions that won't ever do so
  Make more utility functions static
  Provide token prototypes for functions that are external but have no
    header
  Check #if feature test macros are defined where they may not be
  Add a few missing includes
  Don't shadow the err() function with a local var
  Don't shadow stat with a local variable
  Don't shadow the mask parameter with a local variable in the same
    function
  Don't shadow the chroot global
  Avoid warnings about shifting more bits than we have
  Avoid type-punned pointers that break strict-aliasing

 include/elf.h                                      |    1 +
 include/stdio.h                                    |   15 ++++++---
 ldso/ldso/arm/dl-sysdep.h                          |    3 +-
 ldso/ldso/dl-elf.c                                 |    4 ++-
 ldso/ldso/dl-startup.c                             |    3 +-
 libc/inet/getaddrinfo.c                            |    9 +++--
 libc/misc/elf/dl-support.c                         |    5 +--
 libc/misc/fnmatch/fnmatch.c                        |    2 +-
 libc/sysdeps/linux/arm/aeabi_assert.c              |    5 +--
 libc/sysdeps/linux/arm/aeabi_atexit.c              |    4 +-
 libc/sysdeps/linux/arm/aeabi_errno_addr.c          |    4 +-
 libc/sysdeps/linux/arm/aeabi_localeconv.c          |    4 +-
 libc/sysdeps/linux/arm/aeabi_memclr.c              |    4 +-
 libc/sysdeps/linux/arm/aeabi_memcpy.c              |    4 +-
 libc/sysdeps/linux/arm/aeabi_memmove.c             |    4 +-
 libc/sysdeps/linux/arm/aeabi_memset.c              |    4 +-
 libc/sysdeps/linux/arm/aeabi_unwind_cpp_pr1.c      |   15 +++-----
 libc/sysdeps/linux/arm/find_exidx.c                |    4 +-
 libc/sysdeps/linux/arm/posix_fadvise.c             |    6 ++-
 libm/s_scalbn.c                                    |    1 +
 libpthread/linuxthreads.old/cancel.c               |    6 ++--
 libpthread/linuxthreads.old/libc_pthread_init.c    |    4 +-
 libpthread/linuxthreads.old/manager.c              |    8 ++--
 libpthread/linuxthreads.old/pthread.c              |    2 +-
 libpthread/linuxthreads.old/ptlongjmp.c            |    4 +-
 libpthread/linuxthreads.old/specific.c             |    2 +-
 .../linuxthreads.old/sysdeps/arm/pt-machine.h      |    4 +-
 .../linuxthreads.old_db/td_thr_tls_get_addr.c      |    2 +-
 librt/shm.c                                        |    1 +
 utils/chroot_realpath.c                            |   13 +++++---
 utils/ldconfig.c                                   |   34 ++++++++++----------
 utils/ldd.c                                        |   16 +++++-----
 utils/readsoname2.c                                |    2 +-
 33 files changed, 107 insertions(+), 92 deletions(-)