[git commit] syscall: unify common syscall defines

Mike Frysinger vapier at gentoo.org
Mon Jul 13 09:28:26 UTC 2009


On Monday 13 July 2009 02:51:11 Carmelo AMOROSO wrote:
> Mike Frysinger wrote:
> > On Thursday 09 July 2009 14:24:32 Mike Frysinger wrote:
> >> On Thursday 09 July 2009 03:35:05 Carmelo AMOROSO wrote:
> >>> Mike Frysinger wrote:
> >>>> commit:
> >>>> http://git.uclibc.org/uClibc/commit/?id=b387d762361e6c109c6a60bced003e
> >>>>7 24 47b0a33 branch:
> >>>> http://git.uclibc.org/uClibc/commit/?id=refs/heads/master
> >>>>
> >>>> Patch is too large, so refusing to show it
> >>>>
> >>>>
> >>>> Unify all the common syscall defines in syscalls-common.h and scrub
> >>>> all the duplicated code from relevant ports.  This should also make
> >>>> converting existing ports to INLINE_SYSCALL() much easier as they
> >>>> don't have to get lost in all the unrelated noise, as well as creating
> >>>> new ports.
> >>>
> >>> this breaks sh4 build on master. I'll see and fix it.
> >>> We are merging this patch in nptl branch and test it for sh4.
> >>
> >> you're probably referring to sh/syscall.c.  my new MAKEALL script didnt
> >> detect my host cross-compiler ... i'll fix that well.
> >>
> >> as for the issue at hand, seems i should add common defines for
> >> XXX_NCS() syscall variants.  i couldnt find any examples before of where
> >> these would be useful, but syscall.c is something that could be moved to
> >> common code now once this is done.  i'll take care of it and hopefully
> >> that'll fix sh in the fallout.
> >
> > ive committed this and superh's sycall.c builds for me now.  the
> > defconfig fails in memcpy.S, but that isnt my fault ;).
>
> it builds fine with my config.
> May you send your defconfig and/or the  build log to check it ?

there is no "my" defconfig, there is only "the" defconfig.

if you run `./extra/scripts/MAKEALL sh`, does it work for you ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20090713/7fd327e3/attachment.pgp>


More information about the uClibc mailing list