errno.h does not properly include uCLibc_errno.h header

Khem Raj raj.khem at gmail.com
Thu Jan 22 18:46:50 UTC 2009


On Thu, Jan 22, 2009 at 9:36 AM, Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
> Folks,
> looking at include/errno.h I've noted that the following line:
>
> #if defined _LIBC && ( defined IS_IN_libc || defined NOT_IN_libc )
> #include <bits/uClibc_errno.h>
> #endif
>
> IIUC, we would wand to include uClibc_errno.h only if we are inside
> uclibc/libc
>
> so, I imagine we should use
> #if defined _LIBC && ( defined IS_IN_libc || ! defined NOT_IN_libc )

IIUC  NOT_IN_libc is defined by libraries that we build along with
libc which have access to libc sources when they are built but are not
libc (e.g. librt )
and _LIBC is defined for libc code. Unless we want to bar these
associated libraries from including bits/uClibc_errno.h the current
check should be ok.

>
> is it right, or am I completely wrong ?
>
> Carmelo
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc
>


More information about the uClibc mailing list