[PATCH] sh: Fix __SH_SYSCALL_TRAP_BASE for SH2A architecture

Carmelo AMOROSO carmelo.amoroso at st.com
Fri Feb 20 14:59:11 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bernhard Reutner-Fischer wrote:
> On Fri, Feb 20, 2009 at 03:18:04PM +0100, Bernhard Reutner-Fischer wrote:
>> On Fri, Feb 20, 2009 at 03:12:34PM +0100, Carmelo AMOROSO wrote:
>>
>>>>>> +#ifdef __CONFIG_SH2__ | __CONFIG_SH2A__ 
>>>>>>  # define __SH_SYSCALL_TRAP_BASE 0x20
>>>>>>  #else
>>>>>>  # define __SH_SYSCALL_TRAP_BASE 0x10
>>>>> Applied, thanks.
>>>> err, how could that possibly be correct?
>>>>
>>> It cannot. Sorry.. just applied. Luckily there are more eyes looking at
>>> what we do.
>> alright, don't get me wrong but please let's just do this properly via
>> #if defined FOO || defined BAR
> 
> oh, and probably -DFOO=__sh2__ -DBAR=__SH2A__
why ? I would expect to be defined by gcc itself.
At least cross gcc for sh4 defines the following

#define __sh__ 1
#define __SH4__ 1

> Perhaps you know if a BAZ (aka __SH2E__) should be there too..
not listed among SH subarch. I don't know.

>> TIA and sorry for the nitpicking ;P
> 
You must do this !!! ;-)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmexT8ACgkQoRq/3BrK1s9lgQCdHLHNmGMOXnVNV6CrO2M1sQeU
mEEAn2pZidPhDymPUvZgxvMKjo4FzLFy
=ztjL
-----END PGP SIGNATURE-----


More information about the uClibc mailing list