0.9.30.1 review - svn 24052

[Rob Landley]

Svn 24052 is a poorly-defined patch mixes at least four seemingly unrelated 
things:

1) It adds UCLIBC_HAS_SSP support to various makefile  like nsl and libresolv.

2) It uses #if 0/#endif to chop out a largeish portion of 
include/sys/sysinfo.h (no idea why), and it adds 8 zillion #ifdef 
__UCLIBC_LINUX_SPECIFIC__ things when linux is the only target uClibc has 
historically _ever_ supported.

3) It renames a local variable in libc/inet/ifaddrs.c:map_newlink() from 
"index" to "idx".

4) It adds and #ifdef __UCLIBC_LINUX_SPECIFIC__ to a lot of places that 
already have a __USE_GNU.  Apparently, this needed a synonym.

I'm confused why UCLIBC_LINUX_SPECIFIC exists in the first place since Linux 
is the only platform uClibc has ever supported and you can't build the sucker 
without Linux kernel headers, but I guess it's just one more way of defining a 
set of optional functionality to remove for size reasons.  But in this case, 
it's adding stuff to _headers_ (making them larger, not removing any code from 
the binary).

I also note that the help for the config entry for UCLIBC_LINUX_SPECIFIC from 
0.9.30 provides an explicit list of functions to be inexplicably removed: 
fstatfs(), inotify_*(), ioperm(), iopl(), madvise(), modify_ldt(), 
personality(), ppoll(), setresuid(), signalfd().  This presumably extends that 
list (one of the few places it's not merely a synonym for __USE_GNU is where 
it inexplicably chops out vhangup()), but this patch does not modify that help 
entry.

This patch is a bugfix?  For _what_?

Rob