[PATCH] check if USE_TLS is defined before use

[Hans-Christian Egtvedt]

On Wed, 16 Dec 2009 15:40:05 +0100
Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hans-Christian Egtvedt wrote:
> > On Wed, 16 Dec 2009 15:27:13 +0100
> > Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
> > 
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Hans-Christian Egtvedt wrote:
> >>> This patch will convert all the #ifdef USE_TLS and #if USE_TLS to
> >>>  #if defined(USE_TLS) && USE_TLS.
> >>>
> >>> By checking if the USE_TLS is defined before checking its value will result in
> >>> correct behavior for architectures not defining this config symbol.
> >>>
> >> Hi,
> >> why not using now __UCLIBC_HAS_TLS__ instead that is defined for NTPL
> >> case, and undefined otherwise ?
> >>
> > 
> > AFAICT it should still separate between USE_TLS 0 and 1, but perhaps
> > the check should be:
> > 
> > #ifdef __UCLIBC_HAS_TLS__ && USE_TLS ?
> > 
> > PS! I have not followed the TLS integration closely.
> > 
> 
> Well, frankly I don't know... your patch is fine for the purpose of fixing
> not TLS arch... probably it can be reviewed again later... we are quite near to
> the final integration.
>

Okay, there might be some of them present in libpthread/linuxthreads as
well, but are there really a lot of users of !old implementation? I
have found the old linuxthreads to be most stable, and I guess one of
them will be nuked when NPTL has been out for a release or two?

> Can you push ? please could you cherry-pick into nptl branch too ?
> 

Ah, right, all the devs push directly to the master repo after review.
I guess I should add Acked-by from you?

-- 
Best regards,
Hans-Christian Egtvedt