[PATCH] check if USE_TLS is defined before use

Carmelo AMOROSO carmelo.amoroso at st.com
Wed Dec 16 14:40:05 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hans-Christian Egtvedt wrote:
> On Wed, 16 Dec 2009 15:27:13 +0100
> Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hans-Christian Egtvedt wrote:
>>> This patch will convert all the #ifdef USE_TLS and #if USE_TLS to
>>>  #if defined(USE_TLS) && USE_TLS.
>>>
>>> By checking if the USE_TLS is defined before checking its value will result in
>>> correct behavior for architectures not defining this config symbol.
>>>
>> Hi,
>> why not using now __UCLIBC_HAS_TLS__ instead that is defined for NTPL
>> case, and undefined otherwise ?
>>
> 
> AFAICT it should still separate between USE_TLS 0 and 1, but perhaps
> the check should be:
> 
> #ifdef __UCLIBC_HAS_TLS__ && USE_TLS ?
> 
> PS! I have not followed the TLS integration closely.
> 

Well, frankly I don't know... your patch is fine for the purpose of fixing
not TLS arch... probably it can be reviewed again later... we are quite near to
the final integration.

Can you push ? please could you cherry-pick into nptl branch too ?

Cheers,
Carmelo


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkso8UQACgkQoRq/3BrK1s/tEQCg/GF21jm+zkQnSfDJnYv4Ohya
/qkAoILQQ4VoQh+Sv0ZPNVpI4V2hT1wE
=yvR7
-----END PGP SIGNATURE-----


More information about the uClibc mailing list