[PATCH] Elf loader unable to load shared libraries.

[Khem Raj]

On Thursday 09 April 2009 01:25:59 am Mike Frysinger wrote:
> On Friday 27 March 2009 11:58:07 Groleo Marius wrote:
> > The attached patches fixes the problems I've encountered:
> 
> please fix your e-mail client so it has patches show up inline/automatically 
> so that it's easier to review
> 
> >  - m68k_cf_no_mmap2.patch
> >
> >     : Disable mmap2() if we're compiling for coldfire and fall back to
> >     : mmap().
> >
> > 	It seems to map a different file area on a 2.6.25 linux kernel.
> > 	I will investigate this further after I'll get a full rootfs.
> 
> considering you're touching common code, you really should investigate the 
> real problem *before* committing.  plus, this looks totally broken to me ... i 
> think it needs to get reverted.
> 
> old logic:
> #if MMAP6ARGS && __NR_mmap
>  ...
> #elif __NR_mmap2
>  ...
> #elif __NR_mmap
>  ...
> #else
> 
> new logic:
> #if MMAP6ARGS && __NR_mmap
>  ...
> #if !defined(coldfire)
> #elif __NR_mmap2
>  ...
> #endif
> #elif __NR_mmap
>  ...
> #else
> 
> or, to write it in C with braces:
> if (MMAP6ARGS && __NR_mmap) {
> 	if (!defined(coldfire)) {
> 		...
> 	} else if (__NR_mmap2) {
> 
> 	}
> } else if (__NR_mmap) {
>  ...
> -mike
> 

hmm, you are right. I corrected it.
-- 
Khem Raj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20090409/731bcccc/attachment.pgp>