[PATCH] all arches: c89 touchup

Carmelo Amoroso carmelo73 at gmail.com
Wed Oct 1 05:37:14 UTC 2008


Bernhard Reutner-Fischer wrote:
> Hi,
> 
> To be gentle to c89 bootstrap-compilers the attached patch does
> basically s/\/\/\(.*\)/\/*\1 *\//g
> 
> The corresponding issue is
> http://bugs.uclibc.org/view.php?id=5194
> 
> The reporter sees this with gcc-4.2.4 without passing -std=c89 to
> the compiler (i.e. uses the defaults) and as such i find it a bit odd
> that the preprocessor rejects it.
> 
> Still, it may be handy if one is able to bootstrap the libc with
> a compiler that is in C89 mode.
> 
> Are there objections from the arch maintainers against the attached
> change?
> 
>  libm/e_lgamma.c                                            |    2 
>  libm/e_gamma.c                                             |    2 
>  libm/e_gamma_r.c                                           |    2 
>  include/fcntl.h                                            |    2 
>  include/libc-symbols.h                                     |    2 
>  utils/ldd.c                                                |    8 
>  ldso/ldso/arm/dl-startup.h                                 |    2 
>  ldso/ldso/powerpc/resolve.S                                |   14 -
>  libc/inet/rpc/rpc_thread.c                                 |    2 
>  libc/string/ia64/memcmp.S                                  |   88 +++---
>  libc/string/ia64/bzero.S                                   |  130 ++++-----
>  libc/string/ia64/strcpy.S                                  |   64 ++--
>  libc/string/ia64/strncmp.S                                 |    6 
>  libc/string/ia64/memcpy.S                                  |  158 +++++------
>  libc/string/ia64/memset.S                                  |  174 ++++++-------
>  libc/string/ia64/memccpy.S                                 |  102 +++----
>  libc/string/ia64/strncpy.S                                 |   90 +++---
>  libc/string/ia64/memmove.S                                 |  160 +++++------
>  libc/string/ia64/strchr.S                                  |   32 +-
>  libc/string/ia64/strlen.S                                  |   18 -
>  libc/string/ia64/strcmp.S                                  |    2 
>  libc/string/ia64/memchr.S                                  |   32 +-
>  libc/string/sh64/strcpy.S                                  |   28 +-
>  libc/string/sh64/memcpy.S                                  |    2 
>  libc/string/sh64/memset.S                                  |   28 +-
>  libc/string/generic/strtok_r.c                             |    8 
>  libc/string/xtensa/strncpy.S                               |  144 +++++-----
>  libc/string/xtensa/strcpy.S                                |   72 ++---
>  libc/string/xtensa/strlen.S                                |   58 ++--
>  libc/string/xtensa/strcmp.S                                |  148 +++++------
>  libc/string/xtensa/memcpy.S                                |   22 -
>  libc/string/xtensa/memset.S                                |   10 
>  libc/string/bfin/strcmp.S                                  |   80 ++---
>  libc/string/bfin/memchr.S                                  |    4 
>  libc/sysdeps/linux/microblaze/__longjmp.S                  |    6 
>  libc/sysdeps/linux/microblaze/vfork.S                      |   10 
>  libc/sysdeps/linux/microblaze/crt0.S                       |   18 -
>  libc/sysdeps/linux/common/bits/uClibc_errno.h              |    2 
>  libc/sysdeps/linux/common/llseek.c                         |    2 
>  libc/sysdeps/linux/v850/__longjmp.S                        |    2 
>  libc/sysdeps/linux/v850/vfork.S                            |    6 
>  libc/sysdeps/linux/v850/crt0.S                             |   20 -
>  libc/sysdeps/linux/xtensa/vfork.S                          |   28 +-
>  libc/sysdeps/linux/xtensa/setjmp.S                         |    2 
>  libc/sysdeps/linux/xtensa/__longjmp.S                      |    6 
>  libc/sysdeps/linux/xtensa/windowspill.S                    |   26 -
>  libc/sysdeps/linux/ia64/setjmp.S                           |   44 +--
>  libc/sysdeps/linux/ia64/__longjmp.S                        |   74 ++---
>  libc/sysdeps/linux/e1/crt1.c                               |    2 
>  libc/sysdeps/linux/nios/bits/endian.h                      |    2 
>  libc/sysdeps/linux/nios/crt1.S                             |    4 
>  libc/sysdeps/linux/sparc/qp_ops.c                          |    2 
>  libc/sysdeps/linux/sh/vfork.S                              |   12 
>  libc/sysdeps/linux/sh/clone.S                              |    6 
>  libc/sysdeps/linux/bfin/__longjmp.S                        |   26 -
>  libc/sysdeps/linux/bfin/bsd-_setjmp.S                      |   22 -
>  libc/misc/internals/tempname.c                             |    2 
>  libpthread/linuxthreads.old/forward.c                      |    4 
>  libpthread/linuxthreads.old/pthread.c                      |    4 
>  libpthread/linuxthreads/pthread.c                          |    4 
>  libpthread/linuxthreads/sysdeps/unix/sysv/linux/sh/vfork.S |    4 
>  61 files changed, 1018 insertions(+), 1018 deletions(-)
> 
> PS: yes, i do not fancy such changes but this is harmless and makes
> sense to some degree.
> PPS: Rob, i know that you like C99 style comments, that's not the point
> here ;)
> 
> 
Absolutely fine for me.
Carmelo
> ------------------------------------------------------------------------
> 
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://busybox.net/cgi-bin/mailman/listinfo/uclibc



More information about the uClibc mailing list