[PATCH] posix_fadvise for ppc32

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Mon Oct 6 10:05:39 UTC 2008


On Sat, Oct 04, 2008 at 08:15:40AM +0200, Carmelo Amoroso wrote:
>Corinna Schultz wrote:
>> These changes are based on the glibc code that handles ppc32.  This
>> probably shouldn't be in the common dir, but I am unfamiliar with how
>> to add code into the arch-specific dir. I am also unsure about the
>> proper symbol to use in the #ifdef; however, this patch worked for us.
>> 
>> It was tested on ia32, and ppc32, and all LTP tests passed. I should  
>> note, that our ppc machine has INTERNAL_SYSCALL defined, so I don't  
>> believe the other code paths were tested.
>> 
>> Suggestions for improvements are welcome.
>> 
>> -Corinna Schultz
>> IBM LTC
>> 
>Hi Corinna,
>usually arch specific implementation will go in separate directory.
>We prefer avoid, whenever possible, adding multiple ifdef inside common code.
>May you kindly post the complete file for powerpc, so we can put it in the right place.

Corinna, look at e.g. ioctl.c which has a powerpc specific "override".



More information about the uClibc mailing list