svn commit: trunk/uClibc/ldso/ldso

Bernhard Fischer rep.dot.nop at gmail.com
Fri May 30 14:41:16 UTC 2008


On Fri, May 30, 2008 at 04:19:26PM +0200, Bernd Schmidt wrote:
>aldot at uclibc.org wrote:
>
>> -	if (!(tpnt->init_flag & RELOCS_DONE))
>> +	if (!(tpnt->init_flag & RELOCS_DONE)) {
>>  		_dl_if_debug_dprint("relocation processing: %s\n", tpnt->libname);
>> -
>> +	}
>
>Seems to me it would be better to fix the macro than all of its callers?

Of course you're right.

So the only immediately annoying thing in ldso remains:
ldso/ldso/dl-elf.c: In function '_dl_load_shared_library':
ldso/ldso/dl-elf.c:201: warning: unused parameter 'tpnt'

If one has turned off RUNPATH support. Not sure if setting
TREE_USED(tpnt)=1 or dropping that parameter is better.
I take it that gcc does not drop dead parameters for obvious reasons,
so i'm leaning towards ifdef'ing it out. Cosmetics.



More information about the uClibc mailing list