facility and prioritynames _again_ [was: Re: svn commit: trunk/uClibc/include/sys]

Denys Vlasenko vda.linux at googlemail.com
Wed Jun 11 15:18:52 UTC 2008


On Wednesday 11 June 2008 14:25, Bernhard Fischer wrote:
> On Thu, Jun 05, 2008 at 07:44:10PM -0700, vda at uclibc.org wrote:
> >Author: vda
> >Date: 2008-06-05 19:44:10 -0700 (Thu, 05 Jun 2008)
> >New Revision: 22241
> >
> >Log:
> >Heed a warning: "string" was assigned to char*, changing that to const char*
> >
...
> 
> In file included from
> /there.pentium4/build_i686/staging_dir/usr/include/syslog.h:1,
>                  from sysklogd/syslogd.c:19:
> /there.pentium4/build_i686/staging_dir/usr/include/sys/syslog.h:77:
> error: conflicting types for 'prioritynames'
> sysklogd/logger.c:30: error: previous declaration of 'prioritynames' was
> here
> /there.pentium4/build_i686/staging_dir/usr/include/sys/syslog.h:128:
> error: conflicting types for 'facilitynames'
> sysklogd/logger.c:31: error: previous declaration of 'facilitynames' was
> here
> make[1]: *** [busybox_unstripped.o] Error 1
> 
> Please fix busybox/sysklogd/logger.c accordingly and make sure that this
> works when compiling against the 0.9.29 release (which doesn't have the
> change above).


Done.

I see why this sysklogd/logger.c hack was necessary, but
there is a cleaner way out of this mess. Not pretty,
but at least it does not attempt to redeclare a structure
to match libc's one...

Can you confirm that attached patch works for you?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9.patch
Type: text/x-diff
Size: 5254 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/uclibc/attachments/20080611/afe7d88a/attachment.bin 


More information about the uClibc mailing list