svn commit: trunk/uClibc/libc/inet

Denys Vlasenko vda.linux at googlemail.com
Fri Jun 6 11:35:39 UTC 2008


On Friday 06 June 2008 12:49, Carmelo AMOROSO wrote:
> Bernd Schmidt wrote:
> >> Author: vda
> >> Date: 2008-06-06 00:25:12 -0700 (Fri, 06 Jun 2008)
> >> New Revision: 22244
> >>
> >> Log:
> >> Use more natural way to return a value in __read_etc_hosts_r:
> >
> >> -	if (buflen < sizeof(char *)*(ALIAS_DIM))
> >> +	if (buflen < sizeof(char *)*ALIAS_DIM)
> >>  		return ERANGE;
> >
> > Again mixing code style and functional changes.
> >
> > Bernd
>
> I strongly agree with the point of Bernd.... avoid pointless change just 
> for cometic, please.

I didn't realize at first how many lines s/(ALIAS_DIM)/ALIAS_DIM/ touched...
You guys are right. Sorry.
--
vda



More information about the uClibc mailing list