cosmetic Makefile fix

[Bernhard Fischer]

On Sat, May 31, 2008 at 08:42:45AM +0200, Denys Vlasenko wrote:
>Hi Bernd,
>
>While testing build system with some scripts I was bitten
>by the cosmetic problem that make is never silent.
>Even if it doesn't build anything, it says
>"make[1]: `conf' is up to date". My scripts were deciding
>that if make says something, it means we see spurious
>rebuilds happening.
>
>I added this TODO for now in top-level Makefile.in:
>
>extra/config/conf extra/config/mconf: include/bits
># TODO: this results in "make[1]: `conf' is up to date" printed
># on every rebuild, because extra/config/conf is already built
># on previous make run. Make it "test -x $@ || ..." (simple & a bit wrong)
># or "make -q -C extra/config $(notdir $@) || ..." (less readable)?
>        $(Q)$(MAKE) -C extra/config $(notdir $@)
>
>In your opinion, which option would be more appropriate here?

I don't see why we need this dependency in the first place?

Does anybody see why we shouldn't just remove it?

With or without it, we miss one crucial dep anyway:
$ make -j 128
[]
./extra/scripts/conf-header.sh .config > include/bits/uClibc_config.h
  CC ldso/ldso/ldso.oS
  AS ldso/ldso/i386/resolve.oS
  CC ldso/libdl/libdl.oS
  CC libc/sysdeps/linux/i386/brk.os
In file included from ./ldso/ldso/i386/dl-syscalls.h:3,
                 from ./ldso/include/dl-syscall.h:12,
                 from ./ldso/include/ldso.h:36,
                 from ldso/ldso/ldso.c:33:
./include/sys/syscall.h:32:25: error: bits/sysnum.h: No such file or
directory

I'm looking into this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uClibc-0.9.29-no-odd-include_bits-dep.patch
Type: text/x-diff
Size: 2136 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/uclibc/attachments/20080604/22205f69/attachment.bin