Prepending underscores to symbol names in dlsym() (commit 20613)
vapier at gentoo.org
Tue Jan 8 15:44:52 UTC 2008
On Tuesday 08 January 2008, Will Newton wrote:
> On Jan 8, 2008 10:14 AM, Paul Mundt <lethal at linux-sh.org> wrote:
> > > Hmm, no, I think what I said is correct. If no underscores is NOT
> > > defined then we prepend the underscore.
> > You both appear to be in agreement on the result. The patch does
> > precisely what is described:
> Incidentally the patch I refer to is not the posted one, the patch I
> was referring to is this one:
the change looks correct to me, and it works on Blackfin, so ...
<do not add _>
so on i386, the code path which prepends _ is not taken
> > > > +++ trunk/uClibc/ldso/include/dl-defs.h 2007-12-03 22:46:53 UTC (rev
> > > > 20613) @@ -175,4 +175,10 @@
> > > > # define DL_MALLOC_ALIGN (__WORDSIZE / 8)
> > > > #endif
> > > >
> > > > +#ifdef __UCLIBC_NO_UNDERSCORES__
> > > > +#define __C_SYMBOL_PREFIX__ ""
> > > > +#else
> > > > +#define __C_SYMBOL_PREFIX__ "_"
> > > > +#endif
> > > > +
> > > > #endif /* _LD_DEFS_H */
> > Additionally, this sort of backwards logic is precisely why having
> > inverted ifdef logic is absolute brain-damage.
i'll drop the _NO_ and invert the ifdefs, but that doesnt involve actually
changing any of the logic of how things work which still means the current
code is correct
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.busybox.net/pipermail/uclibc/attachments/20080108/9ab2b2fa/attachment-0002.pgp
More information about the uClibc