[PATCH] bug in __check_pf() (getaddrinfo.c)

Khem Raj raj.khem at gmail.com
Tue Dec 9 05:11:35 UTC 2008


On (08/12/08 10:35), Carmelo Amoroso wrote:
> On 07/12/2008, Ricard Wanderlof <ricard.wanderlof at axis.com> wrote:
> >
> > On Sat, 6 Dec 2008, Hiroshi Shinji wrote:
> >
> >> Hi Khem,
> >> Thanks for your comment.
> >>
> >> 2008/12/6 Khem Raj <raj.khem at gmail.com>:
> >>> Getting NULL for ifa_addr means that the interface has no address. Do
> >>> you know in what cases does this happen. Patch looks ok though.
> >>
> >> True. My environment has a interface that has no address.
> >>
> >> And, previous source code had another problem. 'for' statement had no
> >> '{' and '}'. Therefore, If you defined both __UCLIBC_HAS_IPV4__ and
> >> __UCLIBC_HAS_IPV6__, the second 'if' statement would be outside of the
> >> for-loop and occure segfault.
> >
> > This stuff seems to continuously come back and haunt me ... :-( (I was the
> > original poster of check_pf-stuff, although it has been modified since
> > then so can't take credit for all the problems. :-) Patch looks good to me
> > anyway.
> >
> > /Ricard
> > --
> > Ricard Wolf Wanderl�f                           ricardw(at)axis.com
> > Axis Communications AB, Lund, Sweden            www.axis.com
> > Phone +46 46 272 2016                           Fax +46 46 13 61 30
> >
> 
> Khem,
> may you give a try at this patch on nptl branch ? I'm wondering if
> this is the cause
> of the segfault we are seeing in sysv-init. I've merged getaddrinfo.c

Carmelo

I tried this patch on arm. Did not help :(

Thx

-Khem



More information about the uClibc mailing list