[PATCH] sh: Fix args for __uClibc_main() in crt1.S

Carmelo AMOROSO carmelo.amoroso at st.com
Fri Aug 8 07:15:32 UTC 2008


Takashi Yoshii wrote:
> Hi,
> 
>> Hum... I think that we are lucky because _dl_fini is defined in ldso.c
>> that includes dl-startup.c that includes dl-startup.h... but if 
>> _dl_fini were defined in another compilation units ? does it work ? am 
>> I correct ?
> Well, that strange structure of the source code tells us that this 
> program is
> more or less under such a restriction, I think.
> But, yes, this one could result some difficulty on future re-construction.
> 
>> My solution is based on a more generic solution using a GOT entry.
>> What is the best solution ? comments ?
> May I? May I say, My code is better because it is 12 bytes smaller!
> as a joke. Thank you.
> Your GOT approach is more generic, and seems to be common seeing other 
> ARCHs does the same(except m68k and mips?). Please feel free to ignore
> my code. I'm happy to see the issue fixed by the combined code.
> 
> Cheers.
> /yoshii
> 

Ok,
I'll commit it. Good collaborative work ;-)

Carmelo



More information about the uClibc mailing list