[PATCH] Re: readahead offset type (re: mantis 0001024)
Bernhard Fischer
rep.dot.nop at gmail.com
Mon Jan 29 19:49:03 UTC 2007
On Mon, Jan 29, 2007 at 07:17:55PM +0100, Asier Llano Palacios wrote:
>I've done this patch to let it compile without LFS.
nah..
What about not building it in the first place?
Index: libc/sysdeps/linux/common/Makefile.in
===================================================================
--- libc/sysdeps/linux/common/Makefile.in (revision 17626)
+++ libc/sysdeps/linux/common/Makefile.in (working copy)
@@ -16,7 +16,7 @@
ifneq ($(UCLIBC_HAS_LFS),y)
CSRC_LFS := $(notdir $(wildcard $(COMMON_DIR)/*64.c))
-CSRC := $(filter-out llseek.c $(CSRC_LFS),$(CSRC))
+CSRC := $(filter-out readahead.c llseek.c $(CSRC_LFS),$(CSRC))
endif
CSRC := $(filter-out ssp-local.c,$(CSRC))
>
>Asier
>
>El lun, 29-01-2007 a las 12:37 -0500, Mark S. Mathews escribió:
>> Hello All,
>>
>> Bug #0001024 (syntax error on offset arg in libc/sysdeps/common/readahead.c)
>> is marked closed, but I ran into it with:
>>
>> uClibc-0.9.28.1,
>> buildroot-17604,
>> gcc-3.4.3
>> binutils-2.17.50.0.10
>> linux-libc-headers-2.4.27
>> target=armeb/xscale
>>
>> Changing off64_t to loff_t (to match sys_readahead in this kernel)
>> seems to work for me.
>>
>> Since loff_t is a kernel-defined type , I'm guessing this isn't a
>> generally acceptable solution.
>>
>> If someone's got some thoughts on the 'right way' to fix it, I'm all ears.
>>
>> Thanks,
>> -Mark
>>
>> Mark S. Mathews
>>
>> AbsoluteValue Systems Web: http://www.linux-wlan.com
>> 721-D North Drive e-mail: mark at linux-wlan.com
>> Melbourne, FL 32934 Phone: 321.259.0737
>> USA Fax: 321.259.0286
>>
>> _______________________________________________
>> uClibc mailing list
>> uClibc at uclibc.org
>> http://busybox.net/cgi-bin/mailman/listinfo/uclibc
>
>----------------------------------------- PLEASE NOTE -------------------------------------------
>This message, along with any attachments, may be confidential or legally privileged.
>It is intended only for the named person(s), who is/are the only authorized recipients.
>If this message has reached you in error, kindly destroy it without review and notify the sender immediately.
>Thank you for your help.
>µSysCom uses virus scanning software but excludes any liability for viruses contained in any attachment.
>
>------------------------------------ ROGAMOS LEA ESTE TEXTO -------------------------------
>Este mensaje y sus anexos pueden contener información confidencial y/o con derecho legal.
>Está dirigido únicamente a la/s persona/s o entidad/es reseñadas como único destinatario autorizado.
>Si este mensaje le hubiera llegado por error, por favor elimínelo sin revisarlo ni reenviarlo y notifíquelo inmediatamente al remitente. Gracias por su colaboración.
>µSysCom utiliza software antivirus, pero no se hace responsable de los virus contenidos en los ficheros anexos.
>diff -urP uClibc-0.9.28.1/libc/sysdeps/linux/common/readahead.c uClibc-0.9.28.1-readahead/libc/sysdeps/linux/common/readahead.c
>--- uClibc-0.9.28.1/libc/sysdeps/linux/common/readahead.c 2007-01-26 01:01:55.000000000 +0100
>+++ uClibc-0.9.28.1-readahead/libc/sysdeps/linux/common/readahead.c 2007-01-29 09:45:31.000000000 +0100
>@@ -23,6 +23,8 @@
> #include <sys/syscall.h>
> #include <bits/wordsize.h>
>
>+#if defined __UCLIBC_HAS_LFS__
>+
> #ifdef __NR_readahead
>
> # define __NR___readahead __NR_readahead
>@@ -50,3 +52,5 @@
> # endif
>
> #endif
>+
>+#endif /* defined __UCLIBC_HAS_LFS__ */
>_______________________________________________
>uClibc mailing list
>uClibc at uclibc.org
>http://busybox.net/cgi-bin/mailman/listinfo/uclibc
More information about the uClibc
mailing list