-fsigned-char on all arches

[Mike Frysinger]

On Wednesday 11 April 2007, Will Newton wrote:
> I noticed there was a change here:
>
> http://www.busybox.net/cgi-bin/viewcvs.cgi/trunk/uClibc/Rules.mak?rev=13205
>&r1=13200&r2=13205
>
> that enabled -fsigned-char for all arches. What was the reasoning
> behind this decision? I'm reliably informed that it generates
> suboptimal code on our architecture.

what dumbass committed that change !

as noted already in this thread, the idea was to make sure latent bugs werent 
introduced in the internal uClibc code due to laziness with "char" type ... i 
doubt any external API's would be affected here nor external ABI broken ...

the macro issue raised by Bernd is a valid point (but i dont think in practice 
applies to any real chunks of code; but i'm guessing)

this should get reverted and perhaps a less-than-cursory scan of the code base 
for possible incorrect utilization (and test cases written when such things 
are found) ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.busybox.net/pipermail/uclibc/attachments/20070415/43e22017/attachment-0002.pgp