svn commit: trunk/uClibc/libc/sysdeps/linux/common

Mike Frysinger vapier at gentoo.org
Sat Sep 9 22:16:54 UTC 2006


On Friday 01 September 2006 12:13, Erik Andersen wrote:
> On Fri Sep 01, 2006 at 01:23:58AM -0400, Mike Frysinger wrote:
> > On Wednesday 30 August 2006 13:12, andersen at uclibc.org wrote:
> > > trunk/uClibc/libc/sysdeps/linux/common/open.c
> > > +int __libc_open(const char *file, int oflag, ...)
> > >  {
> > > -	/* gcc may warn about mode being uninitialized.
> > > -	 * Just ignore that, since gcc is wrong. */
> > > -	mode_t mode;
> > > +	mode_t mode = 0;
> >
> > why ?  as the comment says, the warning can be safely ignored and setting
> > a default value grows the object code a little
>
> Before checking this in, I toyed around with implementing
> __syscall_open2() and __syscall_open3() and using them in each of
> the two open code paths.  That did work nicely and let me keep
> 'mode_t mode' in the CREAT path only, but was bigger so in the
> end I decided to just leave it with this.

so we're going to take the slight increase in size just to silence the 
warning ?  not like the size increase is that bad (like 4 bytes or something)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/uclibc/attachments/20060909/1f1f9bae/attachment-0002.pgp 


More information about the uClibc mailing list