[BUG] missing prototypes for chown and execle
Peter S. Mazinger
ps.m at gmx.net
Fri May 26 07:41:49 UTC 2006
On Thu, 25 May 2006, Mike Frysinger wrote:
> On Friday 19 May 2006 08:47, Peter S. Mazinger wrote:
> > On Fri, 19 May 2006, Amir Shalem wrote:
> > > there are missing prototypes for chown() and execle() in uClibc-snapshot
> > >
> > > I'm attaching a patch to add the missing prototypes
> >
> > I would guard both _proto and _def in exec.c and chown.c w/
> > #ifndef __UNIX98PTY_ONLY__
> > libc_hidden_...(...)
> > #endif
>
> not really worth the effort
>
> if something else starts using the functions should we update the ifdef's ?
I personally like to know, that there is only one user and that in some
special case, if another comes up, remove the guard, but if it is guarded
and something changes around the code, is replaced/removed, then I am
"warned" that there is some superfluos stuff in there
> it isnt like hidden aliases adds overhead at runtime since they get linked
what overhead are you speaking about ("hidden aliases adds overhead at
runtime")
Peter
> out of the final ELF
> -mike
>
--
Peter S. Mazinger <ps dot m at gmx dot net> ID: 0xA5F059F2
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08 BB6E C389 975E A5F0 59F2
More information about the uClibc
mailing list