[PATCH] Could be -DSHARED not defined when building libc.so.0

[Peter S. Mazinger]

On Wed, 12 Jul 2006, Carmelo Amoroso wrote:

> 
> > On Wed, 12 Jul 2006, Carmelo Amoroso wrote:
> >
> >> Hi All,
> >>
> >> looking into libc/Makefile.in,
> >> I suspect that some files could be built without the SHARED macro
> >> defined; the files suffix for objects producing a DSO should be  
> >> oS. So
> >
> > Only those files are compiled with -DSHARED (and produce .oS  
> > object) that
> > have to be different from the version that goes to libc.a, if you  
> > make the
> > proposed change you double the buildtime with no real use.
> 
> Well, to be honest this problem arises into the uClibc-nptl branch,  
> not in the trunk
> (for example libc_pthread_init) I forgot to mention it, sorry for that.

Dont use that branch, because it is broken in many ways due to the fact, 
that it only partly imported changes from trunk and nptl support is not 
completely added (see earlier posts). Look in trunk  
libpthread/linuxthreads/Makefile.in how that file should be compiled, 
there you will see that it will be compiled w/ -DSHARED.

Peter

> By the way, you're right regarding the double compilation, so in my  
> case it's better adding those
> files into the libc-shared-y and libc-static-y list instead of the  
> common one libc-y.
> 
> Carmelo
> 
> > -DSHARED is not mandatory as in the glibc build system.
> >
> > Peter
> >
> >> according to Makerules, each of them will be compiled with -DSHARED (
> >> and -DPIC)
> >>
> >> ... taken from libc/Makefile.in...
> >>
> >> ifeq ($(DOMULTI),n)
> >> libc-so-y = $(libc-y:.o=.os) $(libc-shared-y)
> >> else
> >>
> >> I attached a simple patch
> >>
> >> Carmelo
> >>
> >
> > -- 
> > Peter S. Mazinger <ps dot m at gmx dot net>           ID: 0xA5F059F2
> > Key fingerprint = 92A4 31E1 56BC 3D5A 2D08  BB6E C389 975E A5F0 59F2
> >
> 
> 

-- 
Peter S. Mazinger <ps dot m at gmx dot net>           ID: 0xA5F059F2
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08  BB6E C389 975E A5F0 59F2