[PATCH] Prepare for the VAX architecture
Mike Frysinger
vapier at gentoo.org
Thu Jan 26 02:43:51 UTC 2006
On Wednesday 25 January 2006 16:56, Jan-Benedict Glaw wrote:
> The arch-specific patches are quite separate and won't probably
> interfer with the rest of uClibc.
no point in posting patches which just change whitespace, especially when they
confuse the real code changes ... just apply them yourself separately
unless i missed something, the only *real* change here is this feature:
> +config TARGET_HAS_SIGNED_ZERO_FLOATS
this is a nice big name so it shouldnt be a problem, but normally it's good to
prefix config options with 'UCLIBC' as the option will become part of the
namespace of all applications built with uclibc
> + bool " Target CPU differs between +0.0 and -0.0"
> + default y if !TARGET_vax
> + default n if TARGET_vax
> + depends on UCLIBC_HAS_FLOATS
> + help
> + If your target CPU can differ +0.0 and -0.0 (IEEE floating point
> + support works that way), then you should enable this option.
> +
> + Most people will answer Y, because nearly all CPUs do use IEEE
> + floating point support. VAX CPUs are the rare exception, because
> + they're older than the IEEE standards for floating point
> + representation.
is there a case where you want vax to *not* select this option ? if not, then
i would just use "default n" and then in the Config.vax file, have it do a
'select TARGET_HAS_SIGNED_ZERO_FLOATS' so that for vax targets it's forced on
all the time
> @@ -280,11 +280,11 @@ ssize_t attribute_hidden _fpmaxtostr(FIL
> }
>
> if (x == 0) { /* Handle 0 now to avoid false positive. */
> -#if 1
> +#ifdef __TARGET_HAS_SIGNED_ZERO_FLOATS__
> if (zeroisnegative(x)) { /* Handle 'signed' zero. */
> *sign_str = '-';
> }
> -#endif
> +#endif /* __TARGET_HAS_SIGNED_ZERO_FLOATS__ */
> exp = -1;
> goto GENERATE_DIGITS;
> }
looks fine to me ... you do have commit access now right ?
-mike
More information about the uClibc
mailing list