[patch] Fix MIPS pipe, brk

Mike Frysinger vapier at gentoo.org
Tue Jan 3 14:35:11 UTC 2006


On Tuesday 03 January 2006 06:29, Joseph S. Myers wrote:
> On Tue, 3 Jan 2006, Mike Frysinger wrote:
> > On Monday 02 January 2006 21:58, Joseph S. Myers wrote:
> > > The MIPS implementation of the pipe syscall has various problems, fixed
> > > by this patch:
> >
> > mips/pipe.c isnt actually used in uClibc ... Makefile.arch pulls in
> > pipe.S, not pipe.c ...
>
> My build logs show it using pipe.c, and fixing pipe.c fixes the observed
> problem.  Whatever Makefile.arch says it seems the build system ends up
> preferring the .c version to the .S version.

you're right, that is broken ...

> Maybe removing the .c file 
> would make it use the .S file instead and fix the problems that way; I'd
> need to test this if that's the preferred solution.

that would be the preferred solution, thanks in advance for testing :)

> > > * The list of clobbers for the asm is incomplete; the proper list to
> > > use for all syscalls is that used in bits/syscalls.h.  The brk
> > > implementation has this issue as well, so this patch fixes it for brk
> > > as well as pipe.
> >
> > brk.c that we are using is almost the same as the version used in glibc
> > ... the only difference is below ... so if uClibc brk.c is broken, then
> > the version in glibc is as well right ?
>
> Quite likely; I didn't actually observe a runtime problem caused by the
> incomplete clobbers here, but fixed the clobbers for brk because I found
> it was missing them as well as pipe.  I'll look at fixing this in glibc as
> well.

i'd appreciate it
-mike



More information about the uClibc mailing list