svn commit: branches/uClibc-nptl/libc/sysdeps/linux/common

Peter S. Mazinger ps.m at gmx.net
Mon Feb 13 10:29:35 UTC 2006


On Sat, 4 Feb 2006 sjhill at uclibc.org wrote:

> Author: sjhill
> Date: 2006-02-04 21:50:11 -0800 (Sat, 04 Feb 2006)
> New Revision: 13851
> 
> Log:
> Clean up warnings and cruft.
> 
> 
> Modified:
>    branches/uClibc-nptl/libc/sysdeps/linux/common/getdents.c
>    branches/uClibc-nptl/libc/sysdeps/linux/common/getdents64.c
>    branches/uClibc-nptl/libc/sysdeps/linux/common/syscalls.h
>    branches/uClibc-nptl/libc/sysdeps/linux/common/write.c
> 
> 
> Changeset:
> Modified: branches/uClibc-nptl/libc/sysdeps/linux/common/getdents.c
> ===================================================================
> --- branches/uClibc-nptl/libc/sysdeps/linux/common/getdents.c	2006-02-05 05:46:07 UTC (rev 13850)
> +++ branches/uClibc-nptl/libc/sysdeps/linux/common/getdents.c	2006-02-05 05:50:11 UTC (rev 13851)
> @@ -61,7 +61,7 @@
>      dp = (struct dirent *) buf;
>      skdp = kdp = alloca (red_nbytes);
>  
> -    retval = __syscall_getdents(fd, (char *)kdp, red_nbytes);
> +    retval = __syscall_getdents(fd, (unsigned char *)kdp, red_nbytes);
>      if (retval == -1)
>  	return -1;
>  
> 
> Modified: branches/uClibc-nptl/libc/sysdeps/linux/common/getdents64.c
> ===================================================================
> --- branches/uClibc-nptl/libc/sysdeps/linux/common/getdents64.c	2006-02-05 05:46:07 UTC (rev 13850)
> +++ branches/uClibc-nptl/libc/sysdeps/linux/common/getdents64.c	2006-02-05 05:50:11 UTC (rev 13851)
> @@ -66,7 +66,7 @@
>      dp = (struct dirent64 *) buf;
>      skdp = kdp = alloca (red_nbytes);
>  
> -    retval = __syscall_getdents64(fd, (char *)kdp, red_nbytes);
> +    retval = __syscall_getdents64(fd, (unsigned char *)kdp, red_nbytes);
>      if (retval == -1)
>  	return -1;

do the above kill the warnings w/ gcc4?

>  
> 
> Modified: branches/uClibc-nptl/libc/sysdeps/linux/common/syscalls.h
> ===================================================================
> --- branches/uClibc-nptl/libc/sysdeps/linux/common/syscalls.h	2006-02-05 05:46:07 UTC (rev 13850)
> +++ branches/uClibc-nptl/libc/sysdeps/linux/common/syscalls.h	2006-02-05 05:50:11 UTC (rev 13851)
> @@ -21,7 +21,6 @@
>   */
>  
>  #define _GNU_SOURCE
> -#define _LARGEFILE64_SOURCE
>  #include <features.h>
>  #include <errno.h>
>  #include <sys/types.h>

I don't think this will be ok, the order will make sure, that features.h 
will disable it if LFS is disabled.

Peter

-- 
Peter S. Mazinger <ps dot m at gmx dot net>           ID: 0xA5F059F2
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08  BB6E C389 975E A5F0 59F2




More information about the uClibc mailing list